fix: pre-commit hook raising false alarm #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyujin-cho
added
the
skip:changelog
kyujin-cho
changed the title
kyujin-cho
added a commit
that referenced
this pull request
Apr 7, 2024
Backported-from: main (24.09) Backported-to: 24.03
|
LGTM |
|
Maybe related to pantsbuild/pants#18410. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR of #1998. This PR explicitly marks
alembicas a third party package on ruff's isort config to avoid ruff from think that the package pretending to be a first-party one. Those confusion is caused by ourai.backend.manager.models.alembicpackage having identical name with the third-partyalembic.Checklist: (if applicable)