Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new API to untag image from harbor registry #2010

Merged
merged 23 commits into from Apr 16, 2024
Merged

feat: add new API to untag image from harbor registry #2010

merged 23 commits into from Apr 16, 2024

Conversation

kyujin-cho
Copy link
Member

@kyujin-cho kyujin-cho commented Apr 9, 2024 •
edited

Follow-up PR of #1973.

What's new

  • Append email of the user along with UUID to image label for future reference
  • Add new untag_image_from_registry($image_id: String!) mutation (for now only supports Harbor v2 registries)
  • Update image forget CLI command to automatically untag image before forgetting from Backend.AI's database

Note

After this PR is merged, image forget command will not work with images stored at non-Harbor2 registries.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@kyujin-cho kyujin-cho requested a review from adrysn April 9, 2024 04:52
@kyujin-cho kyujin-cho self-assigned this Apr 9, 2024
@github-actions github-actions bot added comp:client Related to Client component comp:manager Related to Manager component size:M 30~100 LoC labels Apr 9, 2024
@kyujin-cho kyujin-cho added this to the 24.03 milestone Apr 9, 2024
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Apr 9, 2024
@kyujin-cho kyujin-cho changed the title feat: add email address of owner of customized image to image label feat: add owner of customized image's email to image label Apr 9, 2024
@kyujin-cho kyujin-cho changed the title feat: add owner of customized image's email to image label feat: add email of owner of customized image to image label Apr 9, 2024
@kyujin-cho kyujin-cho added comp:client Related to Client component and removed comp:client Related to Client component labels Apr 9, 2024
@kyujin-cho kyujin-cho changed the title feat: add email of owner of customized image to image label feat: add new API to untag image from harbor registry Apr 9, 2024
@kyujin-cho kyujin-cho added comp:client Related to Client component and removed comp:client Related to Client component labels Apr 9, 2024
@kyujin-cho kyujin-cho added comp:client Related to Client component and removed comp:client Related to Client component labels Apr 9, 2024
@kyujin-cho kyujin-cho requested a review from achimnol April 9, 2024 15:21
@agatha197 agatha197 mentioned this pull request Apr 12, 2024
Merged
10 tasks
@kyujin-cho kyujin-cho added comp:client Related to Client component and removed comp:client Related to Client component labels Apr 16, 2024
@kyujin-cho kyujin-cho added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit f60c3d0 Apr 16, 2024
21 of 31 checks passed
@kyujin-cho kyujin-cho deleted the feature/add-user-email-info-to-customized-image branch April 16, 2024 14:45
kyujin-cho added a commit that referenced this pull request Apr 16, 2024
@kyujin-cho @lizable
feat: add new API to untag image from harbor registry (#2010)
ecbe3ec 
Co-authored-by: Jihyun Kang <jihyunkang@lablup.com>
Backported-from: main (24.09)
Backported-to: 24.03
@kyujin-cho kyujin-cho mentioned this pull request May 2, 2024
Open
2 tasks
This was referenced May 8, 2024
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrysn adrysn Awaiting requested review from adrysn

@achimnol achimnol Awaiting requested review from achimnol

Assignees

@kyujin-cho kyujin-cho

Labels
comp:client Related to Client component comp:manager Related to Manager component size:L 100~500 LoC
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyujin-cho @lizable