docs: remove docker compose top-level element 'version' #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrysn
reviewed
Apr 25, 2024
adrysn
requested changes
Apr 25, 2024
adrysn
reviewed
Apr 25, 2024
adrysn
approved these changes
Apr 25, 2024
Merge activity
|
Docker compose 'version' element has been deprecated and shows up with an obsoleted error. On the install from Package guide, remove docker compose top-level element 'version' Following the document https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-top-level-element , The top-level version property is defined by the Compose Specification for backward compatibility. It is only informative. As a result, On the install from Package documents need to remove deprecated top-level version element. Fixed #2034 <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Milestone metadata specifying the target backport version - [ ] Mention to the original issue - [ ] Installer updates including: - Fixtures for db schema changes - New mandatory config options - [ ] Update of end-to-end CLI integration tests in `ai.backend.test` - [ ] API server-client counterparts (e.g., manager API -> client SDK) - [ ] Test case(s) to: - Demonstrate the difference of before/after - Demonstrate the flow of abstract/conceptual models with a concrete implementation - [ v ] Documentation - Contents in the `docs` directory - docstrings in public interfaces and type annotations <!-- readthedocs-preview sorna start --> ---- 馃摎 Documentation preview 馃摎: https://sorna--2035.org.readthedocs.build/en/2035/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 馃摎 Documentation preview 馃摎: https://sorna-ko--2035.org.readthedocs.build/ko/2035/ <!-- readthedocs-preview sorna-ko end -->
adrysn
force-pushed
the
docs/docker-compose-version-element-obsolete
branch
from
3e97190
to
edef020
Compare
graphite-app
bot
deleted the
docs/docker-compose-version-element-obsolete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker compose 'version' element has been deprecated and shows up with an obsoleted error.
On the install from Package guide, remove docker compose top-level element 'version'
Following the document https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-top-level-element , The top-level version property is defined by the Compose Specification for backward compatibility. It is only informative.
As a result, On the install from Package documents need to remove deprecated top-level version element.
Fixed #2034
Checklist: (if applicable)
ai.backend.testdocsdirectory馃摎 Documentation preview 馃摎: https://sorna--2035.org.readthedocs.build/en/2035/
馃摎 Documentation preview 馃摎: https://sorna-ko--2035.org.readthedocs.build/ko/2035/