feat: accept arbitrary name for model definition file #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @kyujin-cho and the rest of your teammates on |
github-actions
bot
added
area:docs
This was referenced Apr 24, 2024
kyujin-cho
force-pushed
the
topic/feat/accept-arbitrary-filename-for-model-definition
branch
from
4e0c3cc
to
57db638
Compare
kyujin-cho
force-pushed
the
topic/feat/accept-arbitrary-filename-for-model-definition
branch
from
57db638
to
73058f5
Compare
achimnol
requested changes
May 3, 2024
...backend/manager/models/alembic/versions/f56a82d0ac9f_add_model_definition_filename_column.py
Outdated
Show resolved
Hide resolved
kyujin-cho
force-pushed
the
topic/feat/accept-arbitrary-filename-for-model-definition
branch
from
73058f5
to
d3bbf12
Compare
achimnol
approved these changes
May 8, 2024
kyujin-cho
force-pushed
the
topic/feat/accept-arbitrary-filename-for-model-definition
branch
from
4787e39
to
87fdc6b
Compare
Merge activity
|
This PR updates model service (endpoint) API implementations in a way of allowing model service to use model definition files other than `model-definition.yaml`. Resolves lablup/giftbox#656. **Checklist:** (if applicable) - [x] Milestone metadata specifying the target backport version - [x] Mention to the original issue <!-- readthedocs-preview sorna start --> ---- 📚 Documentation preview 📚: https://sorna--2063.org.readthedocs.build/en/2063/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 📚 Documentation preview 📚: https://sorna-ko--2063.org.readthedocs.build/ko/2063/ <!-- readthedocs-preview sorna-ko end --> <!-- readthedocs-preview sorna start --> ---- 📚 Documentation preview 📚: https://sorna--2063.org.readthedocs.build/en/2063/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 📚 Documentation preview 📚: https://sorna-ko--2063.org.readthedocs.build/ko/2063/ <!-- readthedocs-preview sorna-ko end -->
kyujin-cho
force-pushed
the
topic/feat/accept-arbitrary-filename-for-model-definition
branch
from
755474d
to
379c4f9
Compare
graphite-app
bot
deleted the
topic/feat/accept-arbitrary-filename-for-model-definition
branch
kyujin-cho
added a commit
that referenced
this pull request
May 28, 2024
This PR updates model service (endpoint) API implementations in a way of allowing model service to use model definition files other than `model-definition.yaml`. Resolves lablup/giftbox#656. **Checklist:** (if applicable) - [x] Milestone metadata specifying the target backport version - [x] Mention to the original issue <!-- readthedocs-preview sorna start --> ---- 📚 Documentation preview 📚: https://sorna--2063.org.readthedocs.build/en/2063/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 📚 Documentation preview 📚: https://sorna-ko--2063.org.readthedocs.build/ko/2063/ <!-- readthedocs-preview sorna-ko end --> <!-- readthedocs-preview sorna start --> ---- 📚 Documentation preview 📚: https://sorna--2063.org.readthedocs.build/en/2063/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 📚 Documentation preview 📚: https://sorna-ko--2063.org.readthedocs.build/ko/2063/ <!-- readthedocs-preview sorna-ko end --> Backported-from: main (24.09) Backported-to: 24.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates model service (endpoint) API implementations in a way of allowing model service to use model definition files other than
model-definition.yaml. Resolves lablup/giftbox#656.Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--2063.org.readthedocs.build/en/2063/
📚 Documentation preview 📚: https://sorna-ko--2063.org.readthedocs.build/ko/2063/
📚 Documentation preview 📚: https://sorna--2063.org.readthedocs.build/en/2063/
📚 Documentation preview 📚: https://sorna-ko--2063.org.readthedocs.build/ko/2063/