-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: accept arbitrary name for model definition file #2063
feat: accept arbitrary name for model definition file #2063
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @kyujin-cho and the rest of your teammates on |
4e0c3cc
to
57db638
Compare
57db638
to
73058f5
Compare
...backend/manager/models/alembic/versions/f56a82d0ac9f_add_model_definition_filename_column.py
Outdated
Show resolved
Hide resolved
73058f5
to
d3bbf12
Compare
4787e39
to
87fdc6b
Compare
Merge activity
|
This PR updates model service (endpoint) API implementations in a way of allowing model service to use model definition files other than `model-definition.yaml`. Resolves lablup/giftbox#656. **Checklist:** (if applicable) - [x] Milestone metadata specifying the target backport version - [x] Mention to the original issue <!-- readthedocs-preview sorna start --> ---- 📚 Documentation preview 📚: https://sorna--2063.org.readthedocs.build/en/2063/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 📚 Documentation preview 📚: https://sorna-ko--2063.org.readthedocs.build/ko/2063/ <!-- readthedocs-preview sorna-ko end --> <!-- readthedocs-preview sorna start --> ---- 📚 Documentation preview 📚: https://sorna--2063.org.readthedocs.build/en/2063/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 📚 Documentation preview 📚: https://sorna-ko--2063.org.readthedocs.build/ko/2063/ <!-- readthedocs-preview sorna-ko end -->
755474d
to
379c4f9
Compare
This PR updates model service (endpoint) API implementations in a way of allowing model service to use model definition files other than `model-definition.yaml`. Resolves lablup/giftbox#656. **Checklist:** (if applicable) - [x] Milestone metadata specifying the target backport version - [x] Mention to the original issue <!-- readthedocs-preview sorna start --> ---- 📚 Documentation preview 📚: https://sorna--2063.org.readthedocs.build/en/2063/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 📚 Documentation preview 📚: https://sorna-ko--2063.org.readthedocs.build/ko/2063/ <!-- readthedocs-preview sorna-ko end --> <!-- readthedocs-preview sorna start --> ---- 📚 Documentation preview 📚: https://sorna--2063.org.readthedocs.build/en/2063/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 📚 Documentation preview 📚: https://sorna-ko--2063.org.readthedocs.build/ko/2063/ <!-- readthedocs-preview sorna-ko end --> Backported-from: main (24.09) Backported-to: 24.03
This PR updates model service (endpoint) API implementations in a way of allowing model service to use model definition files other than
model-definition.yaml
. Resolves lablup/giftbox#656.Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--2063.org.readthedocs.build/en/2063/
📚 Documentation preview 📚: https://sorna-ko--2063.org.readthedocs.build/ko/2063/
📚 Documentation preview 📚: https://sorna--2063.org.readthedocs.build/en/2063/
📚 Documentation preview 📚: https://sorna-ko--2063.org.readthedocs.build/ko/2063/