Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache volume objects in RootContext.get_volume #2081

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Apr 29, 2024

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

Fixes #2078.

Copy link

graphite-app bot commented Apr 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added comp:storage-proxy Related to Storage proxy component size:M 30~100 LoC type:enhance Enhance component, behavior, internals without user-facing features urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! labels Apr 29, 2024
@github-actions github-actions bot added this to the 23.09 milestone Apr 29, 2024
@jopemachine jopemachine marked this pull request as ready for review April 29, 2024 01:52
@kyujin-cho kyujin-cho modified the milestones: 23.09, 24.03, 23.03 Apr 29, 2024
Copy link

graphite-app bot commented Apr 29, 2024

Merge activity

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [x] Milestone metadata specifying the target backport version
- [x] Mention to the original issue

Fixes #2078.
@kyujin-cho kyujin-cho force-pushed the feat/make-storage-proxy-stateful branch from 49ef08d to 98c82f2 Compare April 29, 2024 14:47
@graphite-app graphite-app bot merged commit 98c82f2 into main Apr 29, 2024
26 checks passed
@graphite-app graphite-app bot deleted the feat/make-storage-proxy-stateful branch April 29, 2024 14:51
kyujin-cho pushed a commit that referenced this pull request Apr 29, 2024
Backported-from: main (24.09)
Backported-to: 24.03
kyujin-cho pushed a commit that referenced this pull request Apr 29, 2024
Backported-from: main (24.09)
Backported-to: 23.09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:storage-proxy Related to Storage proxy component size:M 30~100 LoC type:enhance Enhance component, behavior, internals without user-facing features urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make storage-proxy a little more stateful
3 participants