Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow 'DELETE' method for vfolder delete-from-trash API #2082

Closed

Conversation

fregataa
Copy link
Contributor

@fregataa fregataa commented Apr 29, 2024

Currently only POST method is used for vfolder delete-from-trash API.
Let's allow DELETE method for easy usage.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

📚 Documentation preview 📚: https://sorna--2082.org.readthedocs.build/en/2082/


📚 Documentation preview 📚: https://sorna-ko--2082.org.readthedocs.build/ko/2082/

@fregataa fregataa added this to the 24.03 milestone Apr 29, 2024
@fregataa fregataa self-assigned this Apr 29, 2024
Copy link

graphite-app bot commented Apr 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component size:XS ~10 LoC labels Apr 29, 2024
@fregataa
Copy link
Contributor Author

Close this PR because it will be confusing to add endpoint folders/_/delete-from-trash, which is different from folders/delete-from-trash.

@fregataa fregataa closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant