Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace vfolder's status_history's type map with list #2111

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented May 7, 2024

Partially resolves #767.

The current implementation saves only the most recent timestamp whenever status information in status_history is updated, and all previous information is deleted.

This PR prevents the loss of timestamp information by changing the data structure of vfolders' status_history to List.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@github-actions github-actions bot added comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated labels May 7, 2024
@github-actions github-actions bot added the size:M 30~100 LoC label May 7, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jopemachine and the rest of your teammates on Graphite Graphite

@jopemachine jopemachine marked this pull request as ready for review May 7, 2024 06:31
@jopemachine jopemachine changed the title refactor: Replace vfolder's status_history's type map with list refactor: Replace vfolder's status_history's type map with list May 7, 2024
@jopemachine jopemachine closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant