Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make GPFS plugin reliable #2144

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented May 14, 2024

  • Place retrying codes into async-attempt context so that it can actually wait for wait_for seconds.
  • Skip waiting create_fileset job when the given fileset already exists

Tested on real GPFS API server

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

@fregataa fregataa added this to the 24.03 milestone May 14, 2024
@fregataa fregataa self-assigned this May 14, 2024
Copy link

graphite-app bot commented May 14, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added comp:storage-proxy Related to Storage proxy component size:M 30~100 LoC labels May 14, 2024
@fregataa fregataa requested a review from achimnol May 14, 2024 08:43
@fregataa fregataa added the urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! label May 14, 2024
Copy link

graphite-app bot commented May 24, 2024

Merge activity

- Place retrying codes into async-attempt context so that it can actually wait for `wait_for` seconds.
- Skip waiting `create_fileset` job when the given fileset already exists

Tested on real GPFS API server

**Checklist:** (if applicable)

- [x] Milestone metadata specifying the target backport version
- [x] API server-client counterparts (e.g., manager API -> client SDK)
@kyujin-cho kyujin-cho force-pushed the fix/make-gpfs-plugin-reliable branch from ad66af0 to 9cfcad3 Compare May 24, 2024 06:59
@graphite-app graphite-app bot merged commit 9cfcad3 into main May 24, 2024
26 checks passed
@graphite-app graphite-app bot deleted the fix/make-gpfs-plugin-reliable branch May 24, 2024 07:02
lablup-octodog pushed a commit that referenced this pull request May 24, 2024
- Place retrying codes into async-attempt context so that it can actually wait for  seconds.
- Skip waiting  job when the given fileset already exists

Tested on real GPFS API server

**Checklist:** (if applicable)

- [x] Milestone metadata specifying the target backport version
- [x] API server-client counterparts (e.g., manager API -> client SDK)

Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2144
kyujin-cho pushed a commit that referenced this pull request May 28, 2024
Co-authored-by: fregataa <44239739+fregataa@users.noreply.github.com>
Backported-from: main (24.09)
Backported-to: 24.03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:storage-proxy Related to Storage proxy component size:M 30~100 LoC urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant