Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return after create quota to avoid duplicate set-quota request #2145

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fregataa
Copy link
Contributor

@fregataa fregataa commented May 14, 2024

In all inherited QuotaModel, both create_quota_scope() and update_quota_scope() methods create quota scope.
PATCH /quota-scope API conditionally calls both methods and it causes duplicate quota creating jobs.
Let's return right after calling create_quota_scope()

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

@fregataa fregataa added the urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. label May 14, 2024
@fregataa fregataa added this to the 24.03 milestone May 14, 2024
@fregataa fregataa self-assigned this May 14, 2024
Copy link

graphite-app bot commented May 14, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added comp:storage-proxy Related to Storage proxy component size:XS ~10 LoC labels May 14, 2024
@fregataa fregataa added urgency:3 Must be finished within a certain time frame. urgency:4 As soon as feasible, implementation is essential. and removed urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. urgency:3 Must be finished within a certain time frame. labels May 17, 2024
@fregataa fregataa requested a review from kyujin-cho June 8, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:storage-proxy Related to Storage proxy component size:XS ~10 LoC urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants