Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add parameters to check-presets SDK #2153

Merged
merged 7 commits into from
May 28, 2024
Merged

feat: Add parameters to check-presets SDK #2153

merged 7 commits into from
May 28, 2024

Conversation

fregataa
Copy link
Contributor

@fregataa fregataa commented May 16, 2024 •
edited

check-presets API in manager side have group and scaling_group parameters but the counterpart function in SDK does not have them. Let's add those parameters

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

@fregataa fregataa added the urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! label May 16, 2024
@fregataa fregataa added this to the 24.03 milestone May 16, 2024
@fregataa fregataa self-assigned this May 16, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented May 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added comp:client Related to Client component comp:cli Related to CLI component size:S 10~30 LoC labels May 16, 2024
adrysn
adrysn approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@adrysn adrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kyujin-cho kyujin-cho changed the title feature: Add parameters to check-presets SDK function feature: Add parameters to check-presets SDK May 28, 2024
@kyujin-cho kyujin-cho changed the title feature: Add parameters to check-presets SDK feat: Add parameters to check-presets SDK May 28, 2024
@kyujin-cho kyujin-cho merged commit c43686d into main May 28, 2024
28 of 30 checks passed
@kyujin-cho kyujin-cho deleted the feature/add-parameters-to-check-preset-sdk branch May 28, 2024 15:57
lablup-octodog pushed a commit that referenced this pull request May 28, 2024
@fregataa @kyujin-cho
feat: Add parameters to check-presets SDK (#2153)
e2f6016 
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com>
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2153
@lablup-octodog lablup-octodog mentioned this pull request May 28, 2024
Merged
@github-actions GitHub Actions
Copy link

Backport to 24.09 is failed. Please backport manually.

lablup-octodog added a commit that referenced this pull request May 28, 2024
@lablup-octodog @fregataa
feat: Add parameters to check-presets SDK (#2153) (#2209)
f893b63 
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com>

Co-authored-by: Sanghun Lee <sanghun@lablup.com>
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrysn adrysn adrysn approved these changes

@achimnol achimnol Awaiting requested review from achimnol

@kyujin-cho kyujin-cho Awaiting requested review from kyujin-cho

Assignees

@fregataa fregataa

Labels
comp:cli Related to CLI component comp:client Related to Client component size:S 10~30 LoC urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE!
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fregataa @adrysn @kyujin-cho