fix: Wrong image name extraction logic #2391
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing code appears to assume the image name format is
<registry URL>/<namespace>/<image>
backend.ai/src/ai/backend/manager/api/session.py
Lines 1091 to 1103 in f16b76e
If the image name format is
<registry URL>/<namespace>/<project>/<image>
, this logic incorrectly extracts the image name.For example,
new_name includes not only the image name but also the project name.
As a result, in the logic that assigns
new_canonical
, the project name is included twice.(like
ghcr.io/jopemachine/ghcr-test/ghcr-test/python:3.9-ubuntu20.04
)Ref: #2341.
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--2391.org.readthedocs.build/en/2391/
📚 Documentation preview 📚: https://sorna-ko--2391.org.readthedocs.build/ko/2391/