Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add --all option to the ps CLI command #628

Merged
merged 9 commits into from Oct 6, 2022
Merged

feat: Add --all option to the ps CLI command #628

merged 9 commits into from Oct 6, 2022

Conversation

rjwharry
Copy link
Contributor

@rjwharry rjwharry commented Aug 5, 2022 •
edited by achimnol

Adds -a, --all option of backend.ai ps command for alias of backend.ai ps --status ALL.
Resolves #616.

@rapsealk rapsealk added type:feature Add new features effort:easy Need to understand only a specific region of codes (good first issue, easy). comp:client Related to Client component labels Aug 5, 2022
@rapsealk rapsealk added this to the 22.09 milestone Aug 5, 2022
@inureyes inureyes requested a review from achimnol August 7, 2022 14:13
achimnol
achimnol requested changes Aug 8, 2022
View reviewed changes
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the news fragment (changes/628.feature.md), referring the existing release notes to keep the writing style consistent.

rjwharry and others added 2 commits August 8, 2022 22:49
@rjwharry
fix: add changes/628.feature.md fragment
7caba0b
@achimnol
doc: Restyle the news fragment
33219fd 
- "Add A to B" is more natural than "Add A for B"
- Use backquotes to highligt quoted code/command snippets
@achimnol achimnol changed the title feat: add "-a, --all" option feat: Add --all option to the ps CLI command Aug 8, 2022
rjwharry and others added 3 commits August 9, 2022 22:18
@rjwharry
fix: add changes/616.feature.md fragment
a3a9bef
@achimnol @rjwharry
doc: Restyle the news fragment
43e6e34 
- "Add A to B" is more natural than "Add A for B"
- Use backquotes to highligt quoted code/command snippets
@rjwharry
Merge branch 'feature/add-all-option-cli' of github.com:rjwharry/back…
a289b33 
…end.ai into feature/add-all-option-cli

- Fix commit message typo of a3a9bef
@fregataa
Copy link
Contributor

how about prohibiting conflict between status option and all flag or adding a help message "Ignores --status option." like --dead option?

Yaminyam
Yaminyam approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@Yaminyam Yaminyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a very good option

@rapsealk
Copy link
Member

LGTM. Maybe we can discuss replacing --status=ALL with --all in a further issue.

@fregataa fregataa added comp:cli Related to CLI component and removed comp:client Related to Client component labels Oct 4, 2022
fregataa
fregataa approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@fregataa fregataa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I change the label of this PR from "client" to "cli".

kyujin-cho
kyujin-cho approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@kyujin-cho kyujin-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyujin-cho kyujin-cho merged commit 15253b9 into lablup:main Oct 6, 2022
@Yaminyam Yaminyam added the size:S 10~30 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyujin-cho kyujin-cho kyujin-cho approved these changes

@Yaminyam Yaminyam Yaminyam approved these changes

@fregataa fregataa fregataa approved these changes

@achimnol achimnol Awaiting requested review from achimnol

Assignees

@rjwharry rjwharry

Labels
comp:cli Related to CLI component effort:easy Need to understand only a specific region of codes (good first issue, easy). size:S 10~30 LoC type:feature Add new features
Projects
None yet
Milestone
22.09
Development

Successfully merging this pull request may close these issues.

Add "-a, --all" option for "backend.ai ps" command
6 participants
@rjwharry @fregataa @rapsealk @achimnol @kyujin-cho @Yaminyam