Carol's infinite wisdom part 1 #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code quality would be things like following conventions, readability, maintainability, etc-- whereas this book is about *software* quality.
I could also see this resolved by changing the semicolon to a comma: "...love of Java, in fact, as I'll..."
But there's another bit of what it's not below :)
IMO "around" and "~" say the same thing
This is the only place where you use "et cetera"; there are 17 occurrences of "etc".
Yes, I know commits should change only one thing. Deal with it.
Check this to make sure I'm preserving your meaning. I think this is what you were going for, given the following sentences. Unless some witticism just went over my head.
test test test test
Unless you meant to put scare quotes around "requirements" or some other part of this...
Restrained myself from instead changing this to the Pittsburghese "may need specified".
To be internally consistent.
Since you bolded the other criteria, IMO no other words in this section should be bolded. Students love being able to skim for bolded words. I went a step further and put the contrasting phrase in parentheses. Shrug?
|
Whoa! Thank you! However, most have already been fixed! Can you pull down the latest and rebase? |
|
Or, you know, I could just do it, since you're doing me a favor already. =) |
|
Ugh, this is merge hell. I'm just going to review the changes manually. |
| @@ -8,7 +8,7 @@ A long time ago, in a company far, far away, I was a test lead. One of my respo | |||
|
|
|||
| I figured that I could complain about it, or do something about it. I was able to convince the Computer Science department at the University of Pittsburgh to allow me to develop and teach a class on software testing, which has grown to cover many different aspects of software quality, and become a popular, ongoing course (CS 1632: Software Quality Assurance, if you're interested in taking it!). I had to develop my own curriculum, as I couldn't find a good book or syllabus on the subject that struck the right balance between theory and application. Once again, I figured I could either complain about it, or do something about it, and once again, I chose the latter. | |||
|
|
|||
| Understanding how and why software fails, and detecting defects, is a big part of the software development process. A developer who doesn't care about code quality is not a good developer. This book is targeted towards those interested in software testing or writing tests as a developer. If you're interested in quality assurance, or just want to write code with fewer bugs, this book is for you! | |||
| Understanding how and why software fails, and detecting defects, is a big part of the software development process. A developer who doesn't care about software quality is not a good developer. This book is targeted towards those interested in software testing or writing tests as a developer. If you're interested in quality assurance, or just want to write code with fewer bugs, this book is for you! | |||
|
|
|||
|
Thanks, Carol! I am closing this but have made all the changes on a separate commit 48a9b83 |
Closed
|
Thank you!! Sorry I wasn't up to date when I started making changes :-/ And sorry i didn't rebase. I had been making the changes in github's web interface and when I was done i was feeling too lazy to clone. But I've cloned and will make sure to rebase my next round before submitting it! <3 |
25 tasks
timparenti
added a commit
to timparenti/cs1632-ebook
that referenced
this pull request
Sep 24, 2015
The "such a -> such as" fix was missed in 48a9b83.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think I'm going to review more tonight, so here's what I have so far :) MORE TO COME