Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add notes field to region,bundle,pay,auth #986

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

maslow
Copy link
Member

@maslow maslow commented Mar 30, 2023

No description provided.

config Json
notes Note[]
createdAt DateTime @default(now())
updatedAt DateTime @updatedAt
}

// Sms schemas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code review:

  1. The code looks to be syntactically correct and consistent.
  2. The enum NoteLevel is correctly defined and is used in the Note type.
  3. The Note type is correctly defined and is used in several models.
  4. The state and phase properties of the BucketDomain model use the correct types.
  5. The AuthProvider model has the required properties and uses the correct types.
  6. The notes property of the models should be optional and not marked as required.
  7. The createdAt and updatedAt fields of the models should be set automatically and should not be manually set.

@maslow maslow merged commit 206070a into labring:main Mar 30, 2023
@maslow maslow deleted the add-notes branch March 30, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant