allow whitespace in regex

labstack · Jun 26, 2018 · 56091a4 · 56091a4
1 parent 5ac8bed
commit 56091a4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/middleware/rewrite.go b/middleware/rewrite.go
@@ -57,7 +57,7 @@ func RewriteWithConfig(config RewriteConfig) echo.MiddlewareFunc {
 
 	// Initialize
 	for k, v := range config.Rules {
-		k = strings.Replace(k, "*", "(\\S*)", -1)
+		k = strings.Replace(k, "*", "(.*)", -1)
 		config.rulesRegex[regexp.MustCompile(k)] = v
 	}
 

diff --git a/middleware/rewrite_test.go b/middleware/rewrite_test.go
@@ -32,6 +32,9 @@ func TestRewrite(t *testing.T) {
 	req.URL.Path = "/users/jack/orders/1"
 	e.ServeHTTP(rec, req)
 	assert.Equal(t, "/user/jack/order/1", req.URL.Path)
+	req.URL.Path = "/api/new users"
+	e.ServeHTTP(rec, req)
+	assert.Equal(t, "/new users", req.URL.Path)
 }
 
 // Issue #1086