Avoid redirect loop in HTTPSRedirect middleware #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In HTTPSRedirect and similar middlewares, determining if redirection is needed using `c.IsTLS()` causes redirect loop when an application is running behind a TLS termination proxy, e.g. AWS ELB. Instead, I believe, redirection should be determined by `c.Scheme() != "https"`. This works well even behind a TLS termination proxy.
Codecov Report
@@ Coverage Diff @@
## master #1058 +/- ##
==========================================
+ Coverage 78.87% 78.92% +0.05%
==========================================
Files 27 27
Lines 1879 1879
==========================================
+ Hits 1482 1483 +1
+ Misses 283 282 -1
Partials 114 114
Continue to review full report at Codecov.
|
|
@orangain If we move https://github.com/labstack/echo/blob/master/context.go#L233 to the bottom it should work? |
|
@vishr I don't think a position of the if statement affects behavior of redirection. Could you please explain what you concern? |
|
@orangain You are right! |
|
@orangain thanks for your contribution. |
|
When will this be released? It's been almost 30 days since this was merged. Great project! Thanks for all the hard work! |
vishr
pushed a commit
that referenced
this pull request
Mar 12, 2018
Enhancements:
Implemented Response#After()
Dynamically add/remove proxy targets
Rewrite rules for proxy middleware
Add ability to extract key from a form field
Implemented rewrite middleware
Adds a separate flag for the 'http/https server started on' message (#1043)
Applied a little DRY to the redirect middleware (#1053) and tests (#1055)
Simplify dep fetching (#1062)
Add custom time stamp format #1046 (#1066)
Update property name & default value & comment about custom logger
Add X-Requested-With header constant
Return error of context.File in c.contentDisposition
Updated deps
Updated README.md
Fixes:
Fixed Response#Before()
Fixed #990
Fix href url from armor to echo (#1051)
Fixed #1054
Fixed #1052, dropped param alias feature
Avoid redirect loop in HTTPSRedirect middleware (#1058)
Fix deferring body close in middleware/compress test (#1063)
Cleanup code (#1061)
FIX - We must close gzip.Reader, only if no error (#1069)
Fix formatting (#1071)
Can be a fix for auto TLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HTTPSRedirect and similar middlewares, determining if redirection is needed using
c.IsTLS()causes redirect loop when an application is running behind a TLS termination proxy, e.g. AWS ELB.This is because
c.IsTLS()always returnsfalsebehind a TLS termination proxy even when a client connects with TLS.Instead, I believe, redirection should be determined by
c.Scheme() != "https". This works well even behind a TLS termination proxy thanks to aX-Forwarded-Protoheader the proxy sets.