Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header height in the post signed in state #90

Closed
upretiprateek opened this issue Apr 20, 2021 · 9 comments · Fixed by #105
Closed

Header height in the post signed in state #90

upretiprateek opened this issue Apr 20, 2021 · 9 comments · Fixed by #105
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@upretiprateek
Copy link

upretiprateek commented Apr 20, 2021

Once I sign in and go back to the landing page, the header height gets distorted.
(See attached image).

Note: this issue occurred only in the mobile website.

WhatsApp Image 2021-04-20 at 4 16 15 PM

@lacabra lacabra added enhancement New feature or request good first issue Good for newcomers labels Apr 23, 2021
@Msgl
Copy link
Contributor

Msgl commented Apr 23, 2021

Hello @lacabra ! Could you please assign this issue to me? I would like to work on it.

@lacabra
Copy link
Owner

lacabra commented Apr 23, 2021

@upretiprateek can you please provide additional details about your mobile environment? (device and operating system) Because it displays just fine on Brave on iOS, see screenshot below:

IMG_0927

@lacabra
Copy link
Owner

lacabra commented Apr 23, 2021

@Msgl, I have assigned it to you, but before you start working on this you may want to check if it's an issue on your mobile, because it displays fine (and thus it is not an issue) on my end. If we cannot identify the source of the issue that @upretiprateek reports, you may not be able to work on this at all. I suggest you alternatively look into #91

@Msgl
Copy link
Contributor

Msgl commented Apr 23, 2021

@lacabra I checked the application on my mobile and it looks like @upretiprateek 's.

Screenshot_20210423-230626_Chrome

@lacabra
Copy link
Owner

lacabra commented Apr 23, 2021

Great, then you have a good issue to work on, because what you are seeing should not happen.

@Msgl
Copy link
Contributor

Msgl commented Apr 23, 2021

Thank you, I will start working on it!

@Msgl
Copy link
Contributor

Msgl commented Apr 24, 2021

Hello @lacabra , can you please guide me on how to log in to the application on localhost?

Is there somewhere in the code I can find the secret mentioned in the authentication functionalities section below, or can you provide it to me? Also, how should I fill in the rest of the fields (NEXTAUTH_URL, FACEBOOK_ID etc.)?

      "To work with the authentication functionalities, you need to add the following entries to the .env or .env.local:
      SECRET="A secret to use for key generation"
      NEXTAUTH_URL="HOST_URL"
      FACEBOOK_ID="YOUR_FACEBOOK_ID"
      FACEBOOK_SECRET="YOUR_FACEBOOK_SECRET"
      TWITTER_CLIENT_ID="YOUR_TWITTER_CLIENT_ID"
      TWITTER_CLIENT_SECRET="YOUR_TWITTER_CLIENT_SECRET"
      GOOGLE_CLIENT_ID="YOUR_GOOGLE_CLIENT_ID"
      GOOGLE_CLIENT_SECRET="YOUR_GOOGLE_CLIENT_SECRET"
      NEXT_PUBLIC_AUTH_CALLBACK="HOST_URL"
      To obtain the secrets, contact one of the contributors."

@lacabra
Copy link
Owner

lacabra commented Apr 24, 2021

@Msgl I have expanded the documentation on the repo README in be6092c, refer to the updated Developer Environment section.

I can't provide you with the required credentials for security reasons, but it should be easy for you to create your own ones for GitHub, by following these instructions:
https://docs.github.com/en/developers/apps/creating-an-oauth-app

Let me know if you have further questions in this regard.

@Msgl
Copy link
Contributor

Msgl commented Apr 24, 2021

@lacabra thank you!

@lacabra lacabra linked a pull request Apr 29, 2021 that will close this issue
lacabra added a commit that referenced this issue Apr 29, 2021
Header height on mobile Fixes #90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants