Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography setting in User profile #91

Open
upretiprateek opened this issue Apr 20, 2021 · 4 comments · May be fixed by #113
Open

Typography setting in User profile #91

upretiprateek opened this issue Apr 20, 2021 · 4 comments · May be fixed by #113
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@upretiprateek
Copy link

The typography setting in the 'Your mappings' section needs to be updated as per the Zeplin: https://zpl.io/Vx4LdMk

Right now the line height for each achievement is very small and hence the section feels cramped.
Also the text size is smaller than the provided design.

Note: the button 'Map more schools' in User profile needs to be anchored to the bottom of the screen.

@lacabra lacabra added enhancement New feature or request good first issue Good for newcomers labels Apr 23, 2021
@vaishnavi-ch
Copy link

Hi @lacabra I would like to work on this issue, kindly assign it to me.

@lacabra
Copy link
Owner

lacabra commented Apr 23, 2021

Assigned to @vaishnavi-ch. I am aware that you cannot access the Zeplin link, give me a few mins to upload the information contained there over here

@lacabra
Copy link
Owner

lacabra commented Apr 23, 2021

Information from Zeplin below.

This is what this screen should look like (disregard the "Bronze Level" part for now):

Screen Shot 2021-04-23 at 1 53 06 PM

Details of the design:

Screen Shot 2021-04-23 at 1 54 42 PM

As per a similar comment in #92, bear in mind that sizes in Zeplin are set in absolute terms, but in order to be responsive, they have to be set in relative units or percentages on the app.

@vaishnavi-ch
Copy link

@lacabra Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants