Added: AWS Organizations pull flag, account progress tracking. Fixed: Space handling issue in account names. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… space handling in account names.
|
Lacework are you guys going to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
-AWS Organizations pull flag (-o), and accompanying logic to pull all accounts registered via AWS Organizations //disabled accounts fail silently and did not affect asset counts in testing.
-account progress tracking. // This just prints how many accounts are left to be queried and the name of the account the script is currently working on.
Fixed:
-Space handling issue in account names. // This uses BASH IFS modification, and resets it to whatever was used previously when the loop that needs it completes.