feat: Add retrying to component listing #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremydubreil
approved these changes
Mar 16, 2023
| @@ -79,6 +83,13 @@ func LoadState(client *api.Client) (*State, error) { | |||
| return nil, errors.New("invalid api client") | |||
| } | |||
|
|
|||
| func backoffStrategy() *backoff.ExponentialBackOff { | |||
There was a problem hiding this comment.
Is this chosen at random?
There was a problem hiding this comment.
Pretty much - or at least picked as something that seemed reasonable to me. We can tweak if needed (if we continue to observe issues).
edoardopirovano
force-pushed
the
edoardo/retry-component-listing
branch
from
05cbb43
to
b8e800a
Compare
afiune
reviewed
Mar 16, 2023
edoardopirovano
pushed a commit
that referenced
this pull request
Mar 16, 2023
A fair point. Added one in #1193. |
edoardopirovano
added a commit
that referenced
this pull request
Mar 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With SAST and SCA getting increasing usage internally we've stated to hit some API rate limits at installation time. We've already put a mitigation place by starting to cache the installed components in the GitHub Actions cache (lacework/code-security-action#44), but ideally we'd like the installation to be a bit more robust to occasional network glitches and/or rate limits being hit. I suggest adding the retrying code in this PR to our call to the component listing end-point. There's probably more places we could have retrying, but this is pretty much the only place I've actually had reports of failures happening, so let's stick to just here for now.
cc. @lacework/codesec-action