Try to work-around flakyness of the test caused by buffering issues. (f…

…astlane#21792)

We don't have a simple way to disable the buffering in the terminal that is cross platform but quoting the parameter to echo does the job.

fastlane_core/spec/command_executor_spec.rb

@@ -7,7 +7,7 @@
             expect(Process).to receive(:wait)
           end
 
-          result = FastlaneCore::CommandExecutor.execute(command: 'echo foo')
+          result = FastlaneCore::CommandExecutor.execute(command: "echo 'foo'")
 
           expect(result).to eq('foo')
         end
@@ -31,7 +31,7 @@
           # PTY uses "$?" to get exitcode, which is filled in by Process.wait(),
           # so we have to spawn a real process unless we want to mock methods
           # on nil.
-          child_process_id = Process.spawn('echo foo', out: File::NULL)
+          child_process_id = Process.spawn("echo 'foo'", out: File::NULL)
           expect(Process).to receive(:wait).with(child_process_id)
 
           block.yield(fake_std_in, fake_std_out, child_process_id)
@@ -58,18 +58,18 @@
         expect(fake_std_out).to receive(:close)
 
         expect(PTY).to receive(:spawn) do |command, &block|
-          expect(command).to eq('echo foo')
+          expect(command).to eq("echo 'foo'")
 
           # PTY uses "$?" to get exitcode, which is filled in by Process.wait(),
           # so we have to spawn a real process unless we want to mock methods
           # on nil.
-          child_process_id = Process.spawn('echo foo', out: File::NULL)
+          child_process_id = Process.spawn("echo 'foo'", out: File::NULL)
           expect(Process).to receive(:wait).with(child_process_id)
 
           block.yield(fake_std_in, fake_std_out, child_process_id)
         end
 
-        result = FastlaneCore::CommandExecutor.execute(command: 'echo foo')
+        result = FastlaneCore::CommandExecutor.execute(command: "echo 'foo'")
 
         # We are implicitly also checking that the error was not rethrown because that would
         # have crashed the test

fastlane_core/spec/fastlane_pty_spec.rb

@@ -4,7 +4,7 @@
       it 'executes a simple command successfully' do
         @all_lines = []
 
-        exit_status = FastlaneCore::FastlanePty.spawn('echo foo') do |command_stdout, command_stdin, pid|
+        exit_status = FastlaneCore::FastlanePty.spawn("echo 'foo'") do |command_stdout, command_stdin, pid|
           command_stdout.each do |line|
             @all_lines << line.chomp
           end
@@ -16,7 +16,7 @@
       it 'doesn t return -1 if an exception was raised in the block in PTY.spawn' do
         exception = StandardError.new
         expect {
-          exit_status = FastlaneCore::FastlanePty.spawn('echo foo') do |command_stdout, command_stdin, pid|
+          exit_status = FastlaneCore::FastlanePty.spawn("echo 'foo'") do |command_stdout, command_stdin, pid|
             raise exception
           end
         }.to raise_error(FastlaneCore::FastlanePtyError) { |error|
@@ -31,7 +31,7 @@
 
         exception = StandardError.new
         expect {
-          exit_status = FastlaneCore::FastlanePty.spawn('echo foo') do |command_stdout, command_stdin, pid|
+          exit_status = FastlaneCore::FastlanePty.spawn("echo 'foo'") do |command_stdout, command_stdin, pid|
             raise exception
           end
         }.to raise_error(FastlaneCore::FastlanePtyError) { |error|