Deliver sync video #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use MD5 to keep track of the screenshots We delete and re-upload files that had been changed We skip re-upload of files that match md5 and order We delete screenshots if none present locally We don't save if no changes made
We use md5 to keep track of changes in icons Re-upload icon only when changed, or md5 not present in file name on ITC
| <%# we are guaranteed to have at least one element because of the group_by %> | ||
| <h4><%= screenshots[0].formatted_name %></h4> | ||
| <div class="app-screenshot-row"> | ||
|
|
||
| <% if trailer %> | ||
| <video width="400px" height="300px" controls poster="<%= trailer.preview_image_path %>"> |
There was a problem hiding this comment.
move width/height to CSS and use % instead (see existing app-screenshot class one)
|
So here's a first high level review
|
daniszewskik
force-pushed
the
deliver_sync_video
branch
3 times, most recently
from
97c1372
to
e4b8e7d
Compare
|
We also need to update the README ! This part: This part: |
daniszewskik
force-pushed
the
deliver_sync_video
branch
from
e4b8e7d
to
c360292
Compare
| <div class="app-screenshots"> | ||
| <h2 style="color: blue">Skipped Trailers</h2> | ||
| <p> | ||
| Options to skip_trailers activated. <i>Deliver</i> will not modify your app trailers. |
There was a problem hiding this comment.
not need to capitalize. This is referencing the CLI tool.
daniszewskik
force-pushed
the
deliver_sync_video
branch
from
c360292
to
8ba2d3e
Compare
Upload trailers from trailers_path en-US version propagates for all lang versions - ITC works like that removes from ITC if they exist are before uploading new No ffpmeg support No sync trailers yet
daniszewskik
force-pushed
the
deliver_sync_video
branch
from
8ba2d3e
to
63f0061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.