Stop returning null when visible changes #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning null wipes out the modal component, if the state changes too quickly this causes the modal to get stuck on the screen even between reloads. Better to let the modal handles its own visibility change.
PizzaLiu
added a commit
to PizzaLiu/react-native-loading-spinner-overlay
that referenced
this pull request
Sep 19, 2019
|
@niftylettuce Is this still maintained? |
|
Published as v1.1.0 to npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning null wipes out the modal component, if the state changes too quickly this causes the modal to get stuck on the screen even between reloads. Better to let the modal handles its own visibility change.
This should fix #83 and may have positive impacts on #82 #72 and #61 (no guarantee on the latter ones).