Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy #1

Closed
dvv opened this issue Apr 19, 2011 · 8 comments
Closed

proxy #1

dvv opened this issue Apr 19, 2011 · 8 comments

Comments

@dvv
Copy link

dvv commented Apr 19, 2011

Hi!

Please, consider taking care of those who behind proxies ;) Say, https://github.com/dvv/F/blob/master/lib/wget.js

TIA,
--Vladimir

@Filirom1
Copy link

+1

@kapouer
Copy link
Contributor

kapouer commented Mar 24, 2013

This gist from @shigeki looks like it ?
https://gist.github.com/shigeki/2921169
if he's all right with using it.

@anthonyshort
Copy link

^ 👍

@shigeki
Copy link

shigeki commented Mar 26, 2013

I'm very surprised that my gist was founded in this issue thread. This patch is for the man who was in trouble to use tower.js inside his proxy. As described in the gist, it needs node-tunnel module for SSL proxy.
Please free to use or modify this as you like.

@kapouer
Copy link
Contributor

kapouer commented Mar 26, 2013

A second thought about this : it would be easier to have a superagent-proxy module that declares "tunnel" as a dependency, instead of having superagent depend on it directly.

@gjohnson
Copy link
Contributor

Checkout superagent-proxy

@PeterDaveHello
Copy link

PeterDaveHello commented Jul 29, 2016

hmmm ... sorry to comment on an old issue, but I have a question, no offense, can't we just respect the environment variable http_proxy but can only rely on another package? Thanks.

@kornelski
Copy link
Contributor

AFAIK node's own http request handling doesn't automagically pick the proxy, and superagent behaving differently could surprising, so an explicit superagent-proxy call seems like an OK solution to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants