Add support for proxy servers...

[nfreear]

(Not reverse-proxy)

Hi,

I think we'd need to integrate superagent-proxy - how to make this optional?

• See also, proxy ladjs/superagent#1

Ideas?

Thanks,

Nick

[nfreear]

Hmm, does this need adding to chai-http, or is something for the user of the module to integrate?

I think this may have changed from a feature request, into a question.

Would this work...?

var chai = require("chai")
  , chaiHttp = require('chai-http')
  , proxy = 'http://proxy.example.org:80';

chai.use(chaiHttp);

require('superagent-proxy')(chai);

chai
  .request('http://external.example.com')
  .get('/')
  .proxy(proxy)
  .end(function (res) {

});

[keithamus]

Hey again @nfreear 😄. superagent-proxy needs access to the SuperAgent instance, which for chai-http is in chai.request.Test, so your example will almost work - but you need to change require('superagent-proxy')(chai); to require('superagent-proxy')(chai.request.Test);, so the full code:

var chai = require("chai")
  , chaiHttp = require('chai-http')
  , proxy = 'http://proxy.example.org:80';

chai.use(chaiHttp);

require('superagent-proxy')(chai.request.Test);

chai
  .request('http://external.example.com')
  .get('/')
  .proxy(proxy)
  .end(function (res) {

});

Let me know if this works for you and I'll close out the issue 😄

[nfreear]

Hi,

I haven't succeeded in getting it working so far. Fails with:

$ make test-proxy

/Users/ ... /ou-media-player-test/node_modules/superagent-proxy/index.js:97
  if (desc.get == getUrl && desc.set == setUrl) return; // already patched
          ^
TypeError: Cannot read property 'get' of undefined
    at setupUrl (/Users/ ... /ou-media-player-test/node_modules/superagent-proxy/index.js:97:11)
    at Function.proxy (/Users/ ... /ou-media-player-test/node_modules/superagent-proxy/index.js:68:3)
    at setup (/Users/ ... /ou-media-player-test/node_modules/superagent-proxy/index.js:50:18)

• https://github.com/nfreear/ou-media-player-test/blob/master/test/bootstrap/index.js#L34
• https://github.com/TooTallNate/superagent-proxy/blob/master/index.js#L97

Note, you may need this workaround if npm install superagent-proxy fails,

• https://github.com/nfreear/ou-media-player-test#proxy---pre-install

Bit of a puzzle. Yours,

nick

[keithamus]

@nfreear ok. This looks to be because we call our SuperAgent instance "Test" while this plugin is expecting "Request". Should be a simple enough change - simply add a line between 173-174 of request.js saying

module.exports.Request = Test;

And then your first example of chai.use(chaiHttp); should work. If it works, please submit a PR and I'll get it merged ASAP and reward you with a million internet points.

[rjperry611]

For those who see this and don't want to change the module. I got it to work this way (for v1.0):

var chai = require("chai");
var chaiHttp = require("chai-http");
chai.use(chaiHttp);
chai.request.Request = chai.request.Test;
require('superagent-proxy')(chai.request);