[React Native Compat] Don't require window.location to be set #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React Native, is a browser-like environement but some browser properties don't currently make sense in React Native. For example the location object. However, we want our users to be able to use superagent, we even recommend it on our website. https://facebook.github.io/react-native/docs/network.html
amasad
changed the title
defunctzombie
added a commit
that referenced
this pull request
Apr 9, 2015
[React Native Compat] Don't require window.location to be set
|
Thanks for merging it in that quickly :) |
|
A new version on npm would be awesome! |
This was referenced Apr 10, 2015
|
👍 nice |
|
@amasad this weekend |
hyugit
pushed a commit
to BitGo/BitGoJS
that referenced
this pull request
Oct 8, 2015
Summary: all tests passing (255 tests) update superagent to 1.4.0 (latest) react-native requires a newer version of superagent that at least includes a PR from react-native team: ladjs/superagent#621 Reviewers: ben, benchan Reviewed By: benchan Subscribers: ben Differential Revision: https://phabricator.bitgo.com/D1778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native, is a browser-like environement but some browser properties
don't currently make sense in React Native. For example the location
object. However, we want our users to be able to use superagent, we even
recommend it on our website.
https://facebook.github.io/react-native/docs/network.html