Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix end function when piping on request #742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lafeuil
Copy link

@lafeuil lafeuil commented Oct 19, 2021

When I want to pipe to the request :

    const body = Readable.from(JSON.stringify({ name: 'john' }));
    const req = request(app)
      .post('/')
      .set('Content-Type', 'application/json')
      .on('response', function (res) {
        should.exist(res);
        res.status.should.be.equal(200);
        res.text.should.be.equal('john');
        done();
      });
    body.pipe(req);

I have an error Uncaught TypeError: Cannot read property 'call' of undefined

This pull request have :

  • a unit test to reproduce the issue
  • the small fix that removes the call to callback function in the end function if it is empty.

@niftylettuce
Copy link
Collaborator

Have you tried again with latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants