Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated butterfly to work with OF1706+
There has been a change in the naming structure of the image. This is now fixed. Resolved #269
- Loading branch information
1 parent
ee114d3
commit 917b50c
Showing
2 changed files
with
9 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
917b50c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mostaphaRoudsari
Hi there, thank you very much for your excellent works so far. Can I ask if it is possible for butterfly to work with the latest version of OP (1712). If not, should I change some of the lines just like the example you've posted here and what are the lines that I should be changing.
thank you very much.
917b50c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @leeyuan123, I haven't tested the new version but if they haven't changed the naming convention for the image it should work fine with 1712. Butterfly looks for a docker image that starts with
of_
.917b50c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mostaphaRoudsari
Thank you very much for quick reply, it is definitely very appreciated.
I tried to update BF to the version that supports OP1706 by following the manual update instruction you have kindly suggested here. This is how it looks like now in my script folder:
It was very helpful indeed. However, we have this error message says: 1. Solution exception:'type' object has no attribute 'BFVer'. Which I'm not smart enough to figure it out. Can I ask you to offer your wonderful genius to help me solve this problem pls?
Best regard,
Leeyuan
917b50c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there,
I guess I've solved the problem by changing the lines you have suggested on this page and only replace these two files back into the 'butterfly' folder. This is how it looks like now. If this really works, I guess this could be the easiest solution to keep the butterfly up to date on this issue of OP version problem.
However, I'm not sure if the OP is running normally, cause my log folder in outdoor_airflow is empty:
917b50c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leeyuan123, based on the header of readMe butterfly has successfully found the container. The issue can happen for some other reason. I suggest you open an issue on GitHub and see what others have to share. Also the components in your screenshot look old. Try to download the updated example files from GitHub:
https://github.com/ladybug-tools/butterfly-plus/tree/master/plugin/grasshopper/examplefiles
917b50c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, I got the same trouble that my log folder in outdoor_airflow is empty, did you solve this?
917b50c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow these steps to update your installation of Butterfly