Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(building): Ensure height_above_ground works for underground bldgs #553

Merged
merged 1 commit into from Sep 20, 2022
Merged

fix(building): Ensure height_above_ground works for underground bldgs #553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion dragonfly/building.py
View file
Open in desktop
Expand Up @@ -347,7 +347,10 @@ def height(self):
def height_above_ground(self):
"""Get a the height difference between the roof and first floor above the ground.
"""
return self.height - self.unique_stories_above_ground[0].floor_height
try:
return self.height - self.unique_stories_above_ground[0].floor_height
except IndexError: # building completely below ground
return 0

@property
def height_from_first_floor(self):
Expand Down