Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OpenAPI): put all required parameter to the top. #7

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

MingboPeng
Copy link
Member

No description provided.

Copy link
Member

@chriswmackey chriswmackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Do you want to include a test for this similar to what you did here:
https://github.com/ladybug-tools/honeybee-schema/pull/21/files

@chriswmackey
Copy link
Member

On second thought, @MingboPeng , forget my suggestion. I'm realizing that the test runs the _openapi module and this is interfering with the code that gets the current version of the schema to be written into the OpenAPI specification. So let's forego implementing a test like that.

Co-Authored-By: Mostapha Sadeghipour Roudsari <sadeghipour@gmail.com>
@MingboPeng MingboPeng merged commit 30fb419 into ladybug-tools:master Feb 3, 2020
@ladybugbot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants