-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(doe2): Refactor the package to fix several bugs and support new features #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds support for hot water loads
It seems there are 5 numerical properties that have no equivalent in honeybee-core or honeybee-energy since they have to do with the simplified way that DOE-2 models HVAC systems. But BR+A has confirmed that they need them and I can see that they are fairly prominent within the eQuest UI. So I think others will need to set them as well. So we're going to add some RoomDoe2Properties in order to manage them. I'll make some pathways to make these new properties compatible with the old hacky way that this was done with Room.user_data. But these properties will be the long-term solution for this.
chriswmackey
added
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
May 7, 2024
TfedUD
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really really like the generate_inp_string, generate_inp_string_list_format
functions!
🎉 This PR is included in version 0.17.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major improvements include: