Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model): Address the case when holes are closest to upper-left vertex #891

Merged
merged 1 commit into from Aug 4, 2022
Merged

fix(model): Address the case when holes are closest to upper-left vertex #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions honeybee_energy/cli/simulate.py
View file
Open in desktop
Expand Up @@ -35,7 +35,7 @@ def simulate():
type=click.Path(exists=False, file_okay=True, dir_okay=False,
resolve_path=True))
@click.option('--measures', '-m', help='Full path to a folder containing an OSW JSON '
'be used as the base for the execution of the OpenStuduo CLI. While this '
'be used as the base for the execution of the OpenStudio CLI. While this '
'OSW can contain paths to measures that exist anywhere on the machine, '
'the best practice is to copy the measures into this measures '
'folder and use relative paths within the OSW. '
Expand Down Expand Up @@ -74,7 +74,7 @@ def simulate():
@click.option('--check-model/--bypass-check', ' /-bc', help='Flag to note whether '
'the Model should be re-serialized to Python and checked before it '
'is translated to .osm. The check is not needed if the model-file '
'was expored directly from the honeybee-energy Python library. '
'was exported directly from the honeybee-energy Python library. '
'It will be automatically bypassed if the model-file is an OSM or IDF.',
default=True, show_default=True)
@click.option('--enforce-rooms/--skip-no-rooms', ' /-sr', help='Flag to note whether '
Expand Down Expand Up @@ -285,7 +285,7 @@ def simulate_osm(osm_file, epw_file, folder, log_file):
osw_dict = {
'seed_file': osm_file,
'weather_file': epw_file
}
}
osw = os.path.join(folder, 'workflow.osw')
with open(osw, 'w') as fp:
json.dump(osw_dict, fp, indent=4)
Expand Down
2 changes: 1 addition & 1 deletion honeybee_energy/properties/model.py
View file
Open in desktop
Expand Up @@ -1020,7 +1020,7 @@ def add_autocal_properties_to_dict(self, data):
self._add_shade_vertices(face, face_dict)
if face.geometry.has_holes:
face_dict['geometry']['vertices'] = \
[pt.to_array() for pt in face.upper_left_vertices]
[[round(v, 3) for v in pt] for pt in face.upper_left_vertices]
if len(face._apertures) != 0:
for ap, ap_dict in zip(face._apertures, face_dict['apertures']):
self._add_shade_vertices(ap, ap_dict)
Expand Down