Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create): Improve roof_angle description #254

Merged
merged 1 commit into from Aug 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Binary file modified honeybee_grasshopper_core/icon/HB Room from Solid.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions honeybee_grasshopper_core/json/HB_Room_from_Solid.json
@@ -1,5 +1,5 @@
{
"version": "1.2.2",
"version": "1.2.3",
"nickname": "RoomSolid",
"outputs": [
[
Expand Down Expand Up @@ -60,7 +60,7 @@
{
"access": "item",
"name": "_roof_angle_",
"description": "Cutting angle for roof from Z axis in degrees. Default: 30.",
"description": "A number between 0 and 90 to set the threshold below which faces\nwill be considered roofs instead of walls. 90 indicates that all\nvertical faces are roofs and 0 indicates that all horizotnal faces\nare walls. (Default: 30).",
"type": "double",
"default": null
}
Expand Down
7 changes: 5 additions & 2 deletions honeybee_grasshopper_core/src/HB Room from Solid.py
Expand Up @@ -43,7 +43,10 @@
effectively map to OpenStudio space types upon export to OpenStudio.
conditioned_: Boolean to note whether the Rooms have heating and cooling
systems.
_roof_angle_: Cutting angle for roof from Z axis in degrees. Default: 30.
_roof_angle_: A number between 0 and 90 to set the threshold below which faces
will be considered roofs instead of walls. 90 indicates that all
vertical faces are roofs and 0 indicates that all horizotnal faces
are walls. (Default: 30).

Returns:
report: Reports, errors, warnings, etc.
Expand All @@ -53,7 +56,7 @@

ghenv.Component.Name = "HB Room from Solid"
ghenv.Component.NickName = 'RoomSolid'
ghenv.Component.Message = '1.2.2'
ghenv.Component.Message = '1.2.3'
ghenv.Component.Category = 'Honeybee'
ghenv.Component.SubCategory = '0 :: Create'
ghenv.Component.AdditionalHelpFromDocStrings = '2'
Expand Down
Binary file modified honeybee_grasshopper_core/user_objects/HB Room from Solid.ghuser
Binary file not shown.