feat(door): Allow Shades to be assigned to Doors #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently decided that it was weird that people could not assign shades to Doors but they could to all other geometry objects as noted by [this change in the schema](ladybug-tools/honeybee-schema#24). This commit updates the measure to support this new feature and I also put the code that creates shade groups into a function so that we have less copy/pasted code.
chriswmackey
added
enhancement
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently decided that it was weird that people could not assign shades to Doors but they could to all other geometry objects as noted by this change in the schema. This commit updates the measure to support this new feature and I also put the code that creates shade groups into a function so that we have less copy/pasted code.