Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(viewfactor): Ensure View Factor command handles spaces in paths #828

Merged
merged 1 commit into from Jul 4, 2023
Merged

fix(viewfactor): Ensure View Factor command handles spaces in paths #828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions honeybee_radiance/cli/viewfactor.py
View file
Open in desktop
Expand Up @@ -270,7 +270,7 @@ def rcontrib_command_with_view_postprocess(
rcontrib = Rcontrib(options=options, octree=octree, sensors=ray_file)
cmd = rcontrib.to_radiance().replace('\\', '/')
cmd = '{} | rmtxop -fa - -c .333 .333 .334'.format(cmd)
cmd = '{} | getinfo - > {}'.format(cmd, mtx_file.replace('\\', '/'))
cmd = '{} | getinfo - > "{}"'.format(cmd, mtx_file.replace('\\', '/'))
run_command(cmd, env=folders.env)

# load the resulting matrix and process the results into view factors
Expand All @@ -292,7 +292,7 @@ def rcontrib_command_with_view_postprocess(
for facs in view_fac_mtx:
v_file.write(','.join((str(v) for v in facs)) + '\n')
except Exception:
_logger.exception('Failed to comput view factor contributions.')
_logger.exception('Failed to compute view factor contributions.')
sys.exit(1)
else:
sys.exit(0)
Expand Down