Duplicated properties in objects with allof, which makes all properties optional

[MingboPeng]

In all objects with inheritance, it's "properties" field is duplicated at top level (outside of allof), which should not exist. This also makes all properties optional while generating c# client.

I am not sure if this "additionalProperties" is a property or comes with OpenAPI.

cc: @mostaphaRoudsari

[MingboPeng]

@mostaphaRoudsari this might be why our current viewer doesn't like this json file.

[mostaphaRoudsari]

@MingboPeng, can you help me to find this issue by letting me know which file are you looking at?

additionalProperties is a key in OpenAPI: https://swagger.io/docs/specification/data-models/dictionaries/

[mostaphaRoudsari]

I'm seeing it now in the one with inheritance. You might be right. I will give it a try. The documentation is currently broken after the most recent commits. I'm also working on that.

[MingboPeng]

@mostaphaRoudsari Thanks, if I am reading this OpenAPI doc correctly:
additionalProperties should be in this level, right?

In terms of how additionalProperties should be defined:
currently, we don't define any type to this, which means it;s type is object, it can be anything. I am not sure if this will work correctly when translating to json. Should we specify it is a string-to-string dictionary?

[mostaphaRoudsari]

Hi @MingboPeng, See the attached file. This should address both problems that you have raised here:
model_inheritance.zip

Let me know if you see any other issues.

I will push the fix once I can figure out what is going on with the ModelRadianceProperties.

As for additionalProperties we set it to false to not allow users add any other properties than what we have declared.

[MingboPeng]

@mostaphaRoudsari thanks, this works well,

For additionalProperties, I got mixed with userData. I will open another issue for that case.