feat(samples): Add JSON samples for radiance #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds sample JSONs for modifiers, ModidierSets, and for Models with radiance properties. The only tests that it updates are the Model ones, which should pass if @saeranv documents the radiance properties correctly. I leave the writing of tests for modifiers and the ModifierSets to @saeranv .
chriswmackey
added
bug
|
Thanks @chriswmackey, I'm merging it now, and will write the tests tomorrow. |
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds sample JSONs for modifiers, ModidierSets, and for Models with radiance properties.
The only tests that it updates are the Model ones, which should pass if @saeranv documents the radiance properties correctly. I leave the writing of tests for modifiers and the ModifierSets to @saeranv .
@saeranv , I leave this PR for you to merge in when you are ready. I might recommend doing so before you merge in your latest PR so that all of the tests can pass before it's merged.