Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming radiance libraries #3

Closed
mostaphaRoudsari opened this issue Mar 2, 2016 · 2 comments
Closed

Naming radiance libraries #3

mostaphaRoudsari opened this issue Mar 2, 2016 · 2 comments
Assignees
@mostaphaRoudsari
Labels
question

Comments

@mostaphaRoudsari
Copy link
Member

I'm currently naming some libraries under radiance as radiance***. In specific the libraries are radianceparameters and radianceproperties. I'm wondering if I should remove the radiance part since it's already under radiance folder?

from honeybee.radiance import radianceparameters 
# can change to
from honeybee.radiance import parameters

The reason that I currently named them like this is to avoid name conflicts down the road with similar libraries under EnergyPlus but I'm not sure if that's a good reason.

cc: @sariths , @chriswmackey
@sariths
Copy link
Contributor

sariths commented Mar 2, 2016

+1 for from honeybee.radiance import parameters
I agree with you. I don't foresee there being a conflict as you mentioned that parameters specific to radiance will be inside the honeybee.radiance package anyway.

@mostaphaRoudsari
Copy link
Member Author

Thanks @sariths! I will get this fix today.

@mostaphaRoudsari mostaphaRoudsari self-assigned this Mar 2, 2016
mostaphaRoudsari added a commit that referenced this issue Mar 3, 2016
@mostaphaRoudsari
Major changes in library structure
05b6a3e 
These changes will break the current grasshopper implementation.

Here is the summary of changes:
1. Addressed #3 - all the libraries are named with no radiance in name.

2. Addressed #4 - replaced all different methods to toRadString(). Many
of the objects have a minimal input to get a one line string for the
object.

3. Added Custom, Glass and Plastic materials.

4. Broke down sky and material libraries into separate files similar to
command

5. Renamed commands to command

6. Updated documentation in master branch
sariths added a commit that referenced this issue Mar 28, 2016
@sariths
Merge pull request #3 from ladybug-analysis-tools/master
e17d76b 
Gendaymtx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mostaphaRoudsari mostaphaRoudsari

Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mostaphaRoudsari @sariths