Skip to content

Commit

Permalink
fix(to_figure): simplify calculating data range
Browse files Browse the repository at this point in the history
  • Loading branch information
devang-chauhan committed Jan 19, 2022
1 parent 53c377f commit a4547ce
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions ladybug_charts/to_figure.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ def heat_map(hourly_data: Union[HourlyContinuousCollection, HourlyDiscontinuousC
f' Instead got {type(hourly_data)}'

if isinstance(hourly_data, HourlyDiscontinuousCollection):
hourly_data = discontinuous_to_continuous(hourly_data)
hourly_data, data_range = discontinuous_to_continuous(hourly_data)
else:
data_range = [hourly_data.min, hourly_data.max]

var = hourly_data.header.data_type.name
df = dataframe()
Expand All @@ -76,12 +78,11 @@ def heat_map(hourly_data: Union[HourlyContinuousCollection, HourlyDiscontinuousC
if min_range != None and max_range != None:
range_z = [min_range, max_range]
elif min_range != None and max_range == None:
range_z = [min_range, 5 * ceil(df[var].max() / 5)]
range_z = [min_range, data_range[1]]
elif min_range == None and max_range != None:
range_z = [5 * floor(df[var].min() / 5), max_range]
range_z = [data_range[0], max_range]
else:
# Set maximum and minimum according to data
range_z = [5 * floor(df[var].min() / 5), 5 * ceil(df[var].max() / 5)]
range_z = [data_range[0], data_range[1]]

if not colors:
colors = color_set[ColorSet.original.value]
Expand Down

0 comments on commit a4547ce

Please sign in to comment.