Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no euclid support for Python 3. #59

Closed
sariths opened this issue Jul 11, 2018 · 3 comments
Closed

There is no euclid support for Python 3. #59

sariths opened this issue Jul 11, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@sariths
Copy link
Contributor

sariths commented Jul 11, 2018

@mostaphaRoudsari , @chriswmackey

The library crashes if you try to import sunpath in Python 3, as there is currently no "euclid3" in the repo.

I fixed the issue in my fork by adding and renaming the file: sariths@c60f28c

I can send a PR if needed.

@mostaphaRoudsari
Copy link
Member

Try pip install euclid3 for Python 3 and you will have it.

@sariths
Copy link
Contributor Author

sariths commented Jul 11, 2018

Yeah, but I like "stealing" code and putting them in my own repository :P
(And if that is an "official recommendation", then you should add a note about dependencies for usage in Python 3)

@mostaphaRoudsari mostaphaRoudsari self-assigned this Jul 11, 2018
@mostaphaRoudsari mostaphaRoudsari added the enhancement New feature or request label Jul 11, 2018
@saeranv
Copy link
Member

saeranv commented Jul 12, 2018

And I think we should be updating the setup.py file to reflect these dependencies: https://github.com/ladybug-tools/ladybug/blob/master/setup.py

For Python 2, it should be as simple as adding euclid:
install_requires=[
'euclid',
],

And there must be a way to differentiate dependencies based on Python versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants