Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(epw): fixed bug in sky_temperature method #94

Merged
merged 1 commit into from
Dec 1, 2018

Conversation

mostaphaRoudsari
Copy link
Member

We have forgotten to change .values to .data after making the change in DataCollection class.

Added an extra test to catch this issue in the future.

We have forgotten to change .values to .data after making the change in DataCollection class.

Added an extra test to catch this issue in the future.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 253

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 24 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.3%) to 75.373%

Files with Coverage Reduction New Missed Lines %
ladybug/epw.py 2 81.12%
ladybug/datacollection.py 2 50.0%
ladybug/sunpath.py 4 62.46%
ladybug/wea.py 5 88.52%
ladybug/futil.py 11 56.76%
Totals Coverage Status
Change from base Build 246: -0.3%
Covered Lines: 2678
Relevant Lines: 3553

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 253

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 24 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.3%) to 75.373%

Files with Coverage Reduction New Missed Lines %
ladybug/epw.py 2 81.12%
ladybug/datacollection.py 2 50.0%
ladybug/sunpath.py 4 62.46%
ladybug/wea.py 5 88.52%
ladybug/futil.py 11 56.76%
Totals Coverage Status
Change from base Build 246: -0.3%
Covered Lines: 2678
Relevant Lines: 3553

💛 - Coveralls

Copy link
Member

@chriswmackey chriswmackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this one, @mostaphaRoudsari . This one was back from before we switched the data and value properties to be what they should be.

@chriswmackey chriswmackey merged commit 2fdbd97 into master Dec 1, 2018
@mostaphaRoudsari mostaphaRoudsari deleted the fixe_epw_sky_temp branch December 1, 2018 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants