Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pit): Ensure that white spaces in the path can be handled #402

Merged
merged 1 commit into from Sep 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -291,7 +291,7 @@ def output_parameters(self):
return [{'name': 'grids-list', 'from': 'output/grids_info.json', 'to': pathlib.Path(self.params_folder, 'output/grids_info.json').resolve().as_posix()}]


class _PointInTimeGridRayTracing_89d38f18Orchestrator(luigi.WrapperTask):
class _PointInTimeGridRayTracing_727059dcOrchestrator(luigi.WrapperTask):
"""Runs all the tasks in this module."""
# user input for this module
_input_params = luigi.DictParameter()
Expand Down
8 changes: 4 additions & 4 deletions lbt_recipes/point_in_time_grid/flow/main.py
Expand Up @@ -16,7 +16,7 @@
import os
import pathlib
from queenbee_local import QueenbeeTask
from .dependencies.point_in_time_grid_ray_tracing import _PointInTimeGridRayTracing_89d38f18Orchestrator as PointInTimeGridRayTracing_89d38f18Workerbee
from .dependencies.point_in_time_grid_ray_tracing import _PointInTimeGridRayTracing_727059dcOrchestrator as PointInTimeGridRayTracing_727059dcWorkerbee


_default_inputs = { 'grid_filter': '*',
Expand Down Expand Up @@ -62,7 +62,7 @@ def params_folder(self):
return pathlib.Path(self.execution_folder, self._input_params['params_folder']).resolve().as_posix()

def command(self):
return 'honeybee-radiance sky adjust-for-metric {sky} --metric {metric}'.format(sky=self.sky, metric=self.metric)
return 'honeybee-radiance sky adjust-for-metric input.sky --metric {metric}'.format(metric=self.metric)

def requires(self):
return {'GenerateSky': GenerateSky(_input_params=self._input_params)}
Expand Down Expand Up @@ -372,7 +372,7 @@ def map_dag_inputs(self):
return inputs

def run(self):
yield [PointInTimeGridRayTracing_89d38f18Workerbee(_input_params=self.map_dag_inputs)]
yield [PointInTimeGridRayTracing_727059dcWorkerbee(_input_params=self.map_dag_inputs)]
done_file = pathlib.Path(self.execution_folder, 'point_in_time_grid_ray_tracing.done')
done_file.parent.mkdir(parents=True, exist_ok=True)
done_file.write_text('done!')
Expand Down Expand Up @@ -432,7 +432,7 @@ def output(self):
}


class _Main_89d38f18Orchestrator(luigi.WrapperTask):
class _Main_727059dcOrchestrator(luigi.WrapperTask):
"""Runs all the tasks in this module."""
# user input for this module
_input_params = luigi.DictParameter()
Expand Down
2 changes: 1 addition & 1 deletion lbt_recipes/point_in_time_grid/package.json
Expand Up @@ -6,7 +6,7 @@
"type": "MetaData",
"annotations": {},
"name": "point-in-time-grid",
"tag": "0.2.4",
"tag": "0.2.6",
"app_version": null,
"keywords": [
"honeybee",
Expand Down
2 changes: 1 addition & 1 deletion lbt_recipes/point_in_time_grid/run.py
Expand Up @@ -36,7 +36,7 @@ class LetPointInTimeGridFly(luigi.WrapperTask):
_input_params = luigi.DictParameter()

def requires(self):
yield [point_in_time_grid_workerbee._Main_89d38f18Orchestrator(_input_params=self._input_params)]
yield [point_in_time_grid_workerbee._Main_727059dcOrchestrator(_input_params=self._input_params)]


def start(project_folder, user_values, workers):
Expand Down
Expand Up @@ -362,7 +362,7 @@ def output_parameters(self):
return [{'name': 'views-list', 'from': 'output/views_info.json', 'to': pathlib.Path(self.params_folder, 'output/views_info.json').resolve().as_posix()}]


class _PointInTimeViewRayTracing_cdeec518Orchestrator(luigi.WrapperTask):
class _PointInTimeViewRayTracing_2da91d1cOrchestrator(luigi.WrapperTask):
"""Runs all the tasks in this module."""
# user input for this module
_input_params = luigi.DictParameter()
Expand Down
8 changes: 4 additions & 4 deletions lbt_recipes/point_in_time_view/flow/main.py
Expand Up @@ -16,7 +16,7 @@
import os
import pathlib
from queenbee_local import QueenbeeTask
from .dependencies.point_in_time_view_ray_tracing import _PointInTimeViewRayTracing_cdeec518Orchestrator as PointInTimeViewRayTracing_cdeec518Workerbee
from .dependencies.point_in_time_view_ray_tracing import _PointInTimeViewRayTracing_2da91d1cOrchestrator as PointInTimeViewRayTracing_2da91d1cWorkerbee


_default_inputs = { 'metric': 'luminance',
Expand Down Expand Up @@ -64,7 +64,7 @@ def params_folder(self):
return pathlib.Path(self.execution_folder, self._input_params['params_folder']).resolve().as_posix()

def command(self):
return 'honeybee-radiance sky adjust-for-metric {sky} --metric {metric}'.format(sky=self.sky, metric=self.metric)
return 'honeybee-radiance sky adjust-for-metric input.sky --metric {metric}'.format(metric=self.metric)

def requires(self):
return {'GenerateSky': GenerateSky(_input_params=self._input_params)}
Expand Down Expand Up @@ -384,7 +384,7 @@ def map_dag_inputs(self):
return inputs

def run(self):
yield [PointInTimeViewRayTracing_cdeec518Workerbee(_input_params=self.map_dag_inputs)]
yield [PointInTimeViewRayTracing_2da91d1cWorkerbee(_input_params=self.map_dag_inputs)]
done_file = pathlib.Path(self.execution_folder, 'point_in_time_view_ray_tracing.done')
done_file.parent.mkdir(parents=True, exist_ok=True)
done_file.write_text('done!')
Expand Down Expand Up @@ -444,7 +444,7 @@ def output(self):
}


class _Main_cdeec518Orchestrator(luigi.WrapperTask):
class _Main_2da91d1cOrchestrator(luigi.WrapperTask):
"""Runs all the tasks in this module."""
# user input for this module
_input_params = luigi.DictParameter()
Expand Down
4 changes: 2 additions & 2 deletions lbt_recipes/point_in_time_view/package.json
Expand Up @@ -6,7 +6,7 @@
"type": "MetaData",
"annotations": {},
"name": "point-in-time-view",
"tag": "0.2.6",
"tag": "0.2.7",
"app_version": null,
"keywords": [
"honeybee",
Expand Down Expand Up @@ -259,7 +259,7 @@
"type": "DAGStringInput",
"annotations": {},
"name": "view-filter",
"description": "Text for a view identifer or a pattern to filter the views of the model that are simulated. For instance, first_floor_* will simulate only the views that have an identifier that starts with first_floor_. By default, all views in the model will be simulated.",
"description": "Text for a view identifier or a pattern to filter the views of the model that are simulated. For instance, first_floor_* will simulate only the views that have an identifier that starts with first_floor_. By default, all views in the model will be simulated.",
"default": "*",
"alias": [],
"required": false,
Expand Down
2 changes: 1 addition & 1 deletion lbt_recipes/point_in_time_view/run.py
Expand Up @@ -38,7 +38,7 @@ class LetPointInTimeViewFly(luigi.WrapperTask):
_input_params = luigi.DictParameter()

def requires(self):
yield [point_in_time_view_workerbee._Main_cdeec518Orchestrator(_input_params=self._input_params)]
yield [point_in_time_view_workerbee._Main_2da91d1cOrchestrator(_input_params=self._input_params)]


def start(project_folder, user_values, workers):
Expand Down