Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest JDKs #107

Merged
merged 2 commits into from Oct 16, 2019
Merged

Use latest JDKs #107

merged 2 commits into from Oct 16, 2019

Conversation

ignasi35
Copy link
Contributor

No description provided.

@ignasi35 ignasi35 changed the base branch from 1.5.x to 1.6.x October 15, 2019 12:00
@ignasi35 ignasi35 requested a review from a team October 15, 2019 12:01
@TimMoore
Copy link

Travis CI didn't run on this change. Any ideas why?

@TimMoore
Copy link

TimMoore commented Oct 16, 2019

Looking at https://travis-ci.com/lagom/lagom-samples/requests, my guess is that this pull request initially targeted the wrong branch, and Travis CI doesn't see an event when the branch target is updated. I'll close and reopen to trigger it.

We should probably also set it up as a required check for the 1.5.x and 1.6.x branches, so that things aren't merged by mistake without the build running. Update: raised as #108.

@TimMoore TimMoore closed this Oct 16, 2019
@TimMoore TimMoore reopened this Oct 16, 2019
Copy link

@TimMoore TimMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Is there any easier way to specify the latest patch build of each release? Otherwise this will be a constant chore. For example, OpenJDK 8u232 and 11.0.5 were both just tagged today, and I would expect AdoptOpenJDK releases to follow soon.

@TimMoore
Copy link

Had to update the Java 8 version string: 37c2f75

@mergify mergify bot merged commit c5b1e9a into lagom:1.6.x Oct 16, 2019
@TimMoore TimMoore mentioned this pull request Oct 16, 2019
@TimMoore
Copy link

Backport: #110

@ignasi35
Copy link
Contributor Author

Had to update the Java 8 version string: 37c2f75

thanks @TimMoore

@ignasi35
Copy link
Contributor Author

Is there any easier way to specify the latest patch build of each release? Otherwise this will be a constant chore.

There certainly is. We should use the same spell we use on other repos.

@ignasi35
Copy link
Contributor Author

raised #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants