Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different behavior in ScaladslServiceRouter.maybeLogException and JavadslServiceRouter.maybeLogException #2796

Closed
AndreyLadniy opened this issue Apr 1, 2020 · 1 comment · Fixed by #2805
Closed

Different behavior in ScaladslServiceRouter.maybeLogException and JavadslServiceRouter.maybeLogException #2796

AndreyLadniy opened this issue Apr 1, 2020 · 1 comment · Fixed by #2805
Labels
type:defect
Milestone
1.7.0

Comments

@AndreyLadniy
Copy link

Lagom Version (1.2.x / 1.3.x / etc)

1.6.x and below

API (Scala / Java / Neither / Both)

Both

Expected Behavior

ScaladslServiceRouter.maybeLogException and JavadslServiceRouter.maybeLogException there must be the same behavior

Actual Behavior

ScaladslServiceRouter.maybeLogException logs BadRequest exceptions
ihostage added a commit to ihostage/lagom that referenced this issue Apr 6, 2020
@ihostage
lagom#2796 Different behavior in ScaladslServiceRouter.maybeLogExcept…
f48d32c 
…ion and JavadslServiceRouter.maybeLogException
@ihostage ihostage mentioned this issue Apr 6, 2020
Merged
5 tasks
@triage-new-issues triage-new-issues bot removed the triage label Apr 6, 2020
@ihostage
Copy link
Contributor

ihostage commented Apr 6, 2020

I created #2805 to resolve this bug.
Note: Improving exception logging described in #1091.

octonato added a commit that referenced this issue Apr 7, 2020
@octonato
Merge pull request #2805 from ihostage/issue/2796
f6125cf 
#2796 Different behavior in `maybeLogException`
@octonato octonato added this to the 1.6.2 milestone Apr 7, 2020
mergify bot pushed a commit that referenced this issue Apr 7, 2020
@ihostage
#2796 Different behavior in ScaladslServiceRouter.maybeLogException a…
b2a421a 
…nd JavadslServiceRouter.maybeLogException

(cherry picked from commit f48d32c)
@octonato octonato modified the milestones: 1.6.2, 1.7.0 Apr 7, 2020
mergify bot added a commit that referenced this issue Apr 7, 2020
@mergify
Merge pull request #2809 from lagom/mergify/bp/1.6.x/pr-2805
8ccad5a 
#2796 Different behavior in `maybeLogException` (bp #2805)
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:defect
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

#2796 Different behavior in maybeLogException ihostage/lagom
3 participants
@octonato @ihostage @AndreyLadniy