Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting in the Getting Started documentation #51

Closed
fsat opened this issue Mar 17, 2016 · 4 comments
Closed

Code formatting in the Getting Started documentation #51

fsat opened this issue Mar 17, 2016 · 4 comments

Comments

@fsat
Copy link
Contributor

fsat commented Mar 17, 2016

This is in relation to Lagom Getting Started page, particularly the code snippet under Understanding services projects section - http://www.lagomframework.com/documentation/1.0.x/GettingStarted.html#Understanding-services-projects

The code snippet in question is this:

    // Look up the hello world entity for the given ID.
    PersistentEntityRef<HelloCommand> ref = persistentEntityRegistry.refFor(HelloWorld.class, id);

If viewed using the browser the code snippet is truncated at PersistentEntityRef<HelloCommand> ref = persistentEntityRegistry.refFor(HelloWorld.class, - one must scroll to the right to view the code in its entirety.

Because there's no scrollbar, I didn't know there more text to scroll until @dotta told me. We should change the formatting so the whole code is visible without scrolling.

@2m
Copy link
Contributor

2m commented Mar 18, 2016

It looks like the scrollbar is not always missing. It is visible on Ubuntu/Chrome and Archlinux/Chromium.
selection_009

@dotta
Copy link
Contributor

dotta commented Mar 18, 2016

Aha, interesting. For me it's not visible on Max OSX + Chrome.

@jlprat
Copy link

jlprat commented Mar 18, 2016

I filled a bug in lagom docu project about a similar thing, but for android

On Fri, Mar 18, 2016, 10:12 Mirco Dotta notifications@github.com wrote:

Aha, interesting. For me it's not visible on Max OSX + Chrome.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#51 (comment)

@ignasi35
Copy link
Contributor

This seems to be working fine in OSX 10.12.x + Chrome 58
I'll close.

octonato added a commit to octonato/lagom that referenced this issue Apr 26, 2019
* Adds configuration instructions in README file

* Keep using the versioned link for Akka

* Extract & share the code links

* Moves AkkaDiscoveryComponent to own file to avoid links in README

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants