Replace DynamicProjectAdder with sbt.AutoPlugin's extraProjects (bp #2161) #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
dwijnand
force-pushed
the
mergify/bp/1.5.x/pr-2161
branch
from
34315fc
to
4766808
Compare
dwijnand
approved these changes
Aug 14, 2019
(cherry picked from commit 4a518b8)
Otherwise the "docs" build fails with "undefined settings". I suspect because the docs build imports the main build, and "extraProjects" gets confused what is meant by "ThisBuild". This, luckily, works. (cherry picked from commit 179d890) # Conflicts: # dev/sbt-plugin/src/main/scala/com/lightbend/lagom/sbt/LagomPlugin.scala
For some reason can't call "stop" at the root project. ¯\_(ツ)_/¯
[info] [error] Not a valid command: stop (similar: set, last, lastGrep)
[info] [error] No such setting/task
[info] [error] stop
[info] [error] ^
(cherry picked from commit 62eadec)
For some reason can't call "stage" at the root project. ¯\_(ツ)_/¯
[info] [error] Not a valid command: stage (similar: last-grep, set, last)
[info] [error] No such setting/task
[info] [error] stage
[info] [error] ^
(cherry picked from commit c1ad50a)
By declaring the root and its aggregates we workaround sbt's extraProjects bug, which means we can revert the previous workaround of using lagomProj/stage and playProj/stage. (cherry picked from commit e449642)
dwijnand
force-pushed
the
mergify/bp/1.5.x/pr-2161
branch
from
4766808
to
b8ff794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of pull request #2161 done by Mergify.io
Cherry-pick of 179d890 has failed:
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/