Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadSideSlick.md to fix minor typo #3080

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Conversation

cmannix
Copy link

@cmannix cmannix commented Oct 25, 2020

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you signed the Lightbend CLA?
  • [-] Have you added copyright headers to new files?
  • Have you updated the documentation?
  • [-] Have you added tests for any changed functionality?

Purpose

Fixes a small typo in the Slick readside docs (DBIOAciton -> DBIOAction). Apologies if this is too minor, but saw it as I was reading and thought I might as well.

ignasi35
ignasi35 previously approved these changes Oct 26, 2020
@ignasi35 ignasi35 dismissed their stale review October 26, 2020 08:44

Pressed the wrong buttons

@ignasi35
Copy link
Contributor

Hi @cmannix,
thanks for this fix. We generally target the PRs to master and backport to 1.6.x or 1.5.x using mergifyio (https://doc.mergify.io/#). Could you edit the PR and target master instead?

@cmannix cmannix changed the base branch from 1.6.x to master October 26, 2020 09:36
@cmannix
Copy link
Author

cmannix commented Oct 26, 2020

Hi @cmannix,
thanks for this fix. We generally target the PRs to master and backport to 1.6.x or 1.5.x using mergifyio (https://doc.mergify.io/#). Could you edit the PR and target master instead?

Done, let me know if I need to do anything else.

@ignasi35
Copy link
Contributor

This is great, thanks @cmannix

@mergify mergify bot merged commit 12ddd7b into lagom:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants