Fix docs: port to scala, add disclaimer, remove kafka ref. #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimMoore
approved these changes
Mar 17, 2017
TimMoore
pushed a commit
that referenced
this pull request
Mar 17, 2017
|
1.3.x 197ca33 It doesn't apply cleanly to 1.2.x (which doesn't have Scala docs) |
|
1.2.x #598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #595 improved the docs by stating an alternative to PubSub when at-least-once delivery is required. That PR, though, only edited the java/ branch of docs. While reviewing the scala docs I noticed the section edited already suggested falling back to broker API in other situations and included a warning of the side-effects of falling back from PubSub to Broker API.
This needs backporting to
1.3.xand1.2.xbranches.