This repository has been archived by the owner on May 9, 2019. It is now read-only.
Create new testkit project #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimMoore
reviewed
Jul 3, 2017
There was a problem hiding this comment.
Great!
I do have a few small suggestions:
- Normally, we put test utilities that live in a
testkitproject intotestkit/src/main/instead oftestkit/src/test/, and then declare the dependency liketestkit % Testinstead oftestkit % "test -> test". This is because the classes intestkitare a library that is used in tests, they aren't tests themselves. If you want to write unit tests for the test utilities themselves (which is a good idea), those can go intotestkit/src/test/ - This change creates two locations for classes in the
com.example.corepackage: undertoolsand undertestkit. It is usually considered bad practice to split a single package into multiple artifacts this way, as it makes it confusing to know where source code should be located. I think it would be better to put thetestkitcode into a package calledcom.example.testkit. - Maybe
ReadSideTestDrivershould also move intotestkit?
ignasi35
reviewed
Jul 4, 2017
build.sbt
Outdated
| .dependsOn(tools % "test -> test", itemApi, biddingApi) | ||
| .dependsOn( | ||
| tools % "test -> test", | ||
| testkit % "test -> test", |
There was a problem hiding this comment.
Using @TimMoore 's suggestion this dependency will be simplified to testkit % "test".
Moving ReadSideTestDriver to testkit will also simplify tools % "test -> test" into tools.
I'm liking this split into tools and testkit. 👍
ignasi35
approved these changes
Jul 4, 2017
TimMoore
approved these changes
Jul 5, 2017
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.