Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yellow colour should use BLACK text instead of white #21

Closed
djvar94 opened this issue Apr 21, 2020 · 3 comments
Closed

Yellow colour should use BLACK text instead of white #21

djvar94 opened this issue Apr 21, 2020 · 3 comments
Assignees
@lah7
Labels
enhancement New feature or request gtk Affects the colourized theme

Comments

@djvar94
Copy link

djvar94 commented Apr 21, 2020 •
edited
Loading

The current white text on the yellow highlight is really annoying as they're both light colours, it makes it so hard to read, very inconsistent and very bad looking. Here I attach a couple of screenshots I made to give the idea of what I mean. By the way it also affects areas like Firefox's address bar when selecting text, text editors, Evolution, and all the other GTK+3 related programs. Please fix this.

Screenshot at 2020-04-21 18-14-18

Screenshot at 2020-04-21 20-27-44
@lah7 lah7 added the gtk Affects the colourized theme label Apr 23, 2020
@lah7 lah7 self-assigned this Apr 24, 2020
@lah7 lah7 added the enhancement New feature or request label Apr 26, 2020
@lah7 lah7 closed this as completed in cb45c18 Apr 26, 2020
@lah7
Copy link
Owner

lah7 commented Apr 26, 2020

Thanks for the feedback, agreed on the poor contrast.

I've amended the theme - packages will be updated later today.

@lah7 lah7 changed the title Yellow colour should use BLACK text instead of white in things like Ubuntu MATE's menu and Caja Yellow colour should use BLACK text instead of white Apr 26, 2020
@djvar94
Copy link
Author

djvar94 commented Apr 26, 2020 •
edited
Loading

@lah7 It's great. Though the same problem is now in the Dark version of the theme. Please fix that one too thanks.

lah7 added a commit that referenced this issue Apr 26, 2020
@lah7
Process Dark variant for black selected_fg_color.
46f51e4 
Addresses #21
Fixes cb45c18

The values are not identical: #ffffff <> #EBEBEB
@lah7
Copy link
Owner

lah7 commented Apr 26, 2020

Fixed. 🔨 📦 Packages are in the process of being rebuilt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lah7 lah7

Labels
enhancement New feature or request gtk Affects the colourized theme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lah7 @djvar94